Re: [PATCH ath-next 6/8] wifi: ath12k: track per-ring RX sent-to-stack count
Pardeep Kaur <[email protected]> Tue, 28 Jul 2026 17:54:24 +0530
| Newsgroups | org.infradead.lists.ath12k,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 26-07-2026 21:41, Jeff Johnson wrote: > On 7/23/2026 5:54 AM, Pardeep Kaur wrote: >> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c b/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c >> index b203513d63cc..33c4c89eefb5 100644 >> --- a/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c >> +++ b/drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c >> @@ -651,7 +651,10 @@ ath12k_wifi7_dp_rx_process_received_packets(struct ath12k_dp *dp, >> dev_kfree_skb_any(msdu); >> continue; >> } >> - >> + if (likely(ring_id < DP_REO_DST_RING_MAX)) >> + partner_dp->device_stats.sent_to_stack[ring_id]++; > My review agent had the following finding which I did not try to validate: > > sent_to_stack[] is incremented on partner_dp but reo_rx[] is on dp — this > splits correlated stats across two devices' debugfs files in MLO > > In a 2-device MLO group, ath12k_wifi7_dp_rx_process_received_packets() > increments partner_dp->device_stats.sent_to_stack[ring_id] (the msdu's > originating device), while ath12k_wifi7_dp_rx_process() increments > dp->device_stats.reo_rx[ring_id][device_id] (the ring owner). > > Reading /sys/kernel/debug/.../device0/device_dp_stats shows reo_rx[ring0]=N > but sent_to_stack[ring0]=0; device1's file shows the reverse. The two counters > meant to track the same traffic path cannot be compared from a single file. will handle this with adding the device_id and ring id > > >> + else >> + WARN_ON_ONCE(1); >> ath12k_dp_rx_deliver_msdu(dp_pdev, napi, msdu, &rx_info); >> } >>