Re: [PATCH ath-next] wifi: ath12k: add support to load shared firmware on multiPD
Jeff Johnson <[email protected]>
| Newsgroups | org.infradead.lists.ath12k,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 8/11/2026 2:08 AM, Vasanthakumar Thiagarajan wrote:
> On 8/11/2026 11:13 AM, Aaradhana Sahu wrote:
>> +static int ath12k_ahb_load_auth_shared_fw(struct ath12k_base *ab,
>> + struct ath12k_ahb_rproc_info *rproc_info,
>> + const char *fw_name, u32 pasid)
>> +{
>> + int ret;
>> +
>
> nit: move this empty line below after the declaration part.
>
>> + const struct firmware *fw __free(firmware) = NULL;
Note the when using __free() the declaration should be contiguous with the
assignment, so the current format is correct. That is one exception to the
rule about having declarations separate from code.
/jeff