Re: [PATCH wireless-next v3 2/8] wifi: mac80211: change public RX API to use link stations
Devin Wittmayer <[email protected]>
| Newsgroups | org.infradead.lists.ath12k,org.infradead.lists.ath11k,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 20, 2026 at 10:56:14AM -0700, Jeff Johnson wrote: > The fix is trivially `= NULL`. That does fix the first frame in a batch, but it cannot fix the ones after it. The initialiser runs once, at entry, and mt76_rx_complete() reuses the same variable for every frame and again in the A-MSDU loop. So once a frame with a wcid has written a station into it, the next frame without one keeps that station rather than reading NULL. That is the case I measured on an MT7922. Sixteen frames out of roughly 4000 were handed a leftover station, and every one had a wcid-bearing frame ahead of it in the same batch, so an initialiser would not have caught any of them. Clearing it on the no-wcid path inside mt76_rx_convert() covers both. Devin