Re: [PATCH ath-next v2] wifi: ath12k: advertise ieee_link_id in vdev start MLO params

On 6/23/2026 1:46 PM, Manish Dharanenthiran wrote:
> Firmware builds the AP MLD partner profile from the hw_link_id passed in
> the vdev start parameters. However, hw_link_id is not always the same as
> the logical per-MLD ieee_link_id, since ieee_link_id is assigned per MLD
> and not per pdev.
> 
> This matters in mixed MLO and SLO setups. For example:
> 
>   MLD 1 - 5 GHz + 6 GHz (2-link MLO): ieee_link_id 0 and 1
>   MLD 2 - 6 GHz only    (1-link SLO): ieee_link_id 0
>   MLD 3 - 5 GHz only    (1-link SLO): ieee_link_id 0
> 
> The same physical 6 GHz radio can use ieee_link_id 1 for one
> MLD and ieee_link_id 0 for another. Pass the correct ieee_link_id to
> firmware so it can build accurate per-STA profile elements.
> 
> Add ieee_link_id to wmi_vdev_start_mlo_params for the self link and to
> wmi_partner_link_info for each partner link. Populate these fields in
> ath12k_mac_mlo_get_vdev_args() from the corresponding vdev link_id
> before encoding the WMI command.
> 
> Introduce two new flags in ML params to indicate to firmware when
> the new fields are valid:
> 
>   ATH12K_WMI_FLAG_MLO_IEEE_LINK_IDX_VALID         BIT(18) for the self link
>   ATH12K_WMI_FLAG_MLO_IEEE_LINK_IDX_VALID_PARTNER BIT(19) for partner links
> 
> Firmware parses ieee_link_id only when the matching flag is set.
> 
> Also fix the debug message by using correct format specifiers and host-endian
> values instead of __le32 values.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
> 
> Co-developed-by: Hari Naraayana Desikan Kannan <[email protected]>
> Signed-off-by: Hari Naraayana Desikan Kannan <[email protected]>
> Co-developed-by: Karthik M <[email protected]>
> Signed-off-by: Karthik M <[email protected]>
> Signed-off-by: Manish Dharanenthiran <[email protected]>
Reviewed-by: Baochen Qiang <[email protected]>