Re: [PATCH ath-next 1/3] wifi: ath12k: switch to name-based reserved memory lookup

Jeff Johnson <[email protected]>
Newsgroups org.infradead.lists.ath12k,org.kernel.vger.linux-wireless
Message-ID <[email protected]>
On 6/10/2026 8:33 PM, Aaradhana Sahu wrote:
> The driver currently retrieves reserved memory regions using index-based
> lookup, which depends on the ordering of reserved-memory nodes in the
> device tree. Since different platforms define these regions in varying
> orders and combinations, this approach is not compatible and can result
> in incorrect memory region access.
> 
> Switch to looking up memory regions by name instead of index so it does
> not depend on node order.
> 
> Use names already defined in qcom,ipq5332-wifi.yaml, so there are no
> backward compatibility issues.
> 
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Aaradhana Sahu <[email protected]>
> ---
>  drivers/net/wireless/ath/ath12k/ahb.c  | 18 ++++++------
>  drivers/net/wireless/ath/ath12k/core.c | 25 -----------------
>  drivers/net/wireless/ath/ath12k/core.h |  2 --
>  drivers/net/wireless/ath/ath12k/qmi.c  | 38 +++++++++++++-------------
>  4 files changed, 29 insertions(+), 54 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
> index 30733a244454..695b605a92fd 100644
> --- a/drivers/net/wireless/ath/ath12k/ahb.c
> +++ b/drivers/net/wireless/ath/ath12k/ahb.c
> @@ -15,6 +15,7 @@
>  #include "ahb.h"
>  #include "debug.h"
>  #include "hif.h"
> +#include <linux/of_reserved_mem.h>

system includes should come before the local includes. I'd fix this in my tree
except there is another issue in the 3/3 patch so I'll want a v2 for the
entire series.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.