Re: [PATCH v2 ath-current] wifi: ath12k: avoid flushing scan timeout under the wiphy lock
Johannes Berg <[email protected]> Fri, 03 Jul 2026 09:15:42 +0200
| Newsgroups | org.infradead.lists.ath12k,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 2026-07-03 at 14:02 +0800, Runyu Xiao wrote: > > @@ -9975,6 +9974,15 @@ void ath12k_mac_op_stop(struct ieee80211_hw *hw, bool suspend) > > lockdep_assert_wiphy(hw->wiphy); > > + /* > + * scan.timeout takes the wiphy lock before aborting the scan, so do > + * not wait for it from the locked stop path below. > + */ > + wiphy_unlock(hw->wiphy); > No. Don't drop locks in the middle of someone else's (mac80211 here) process. If that work requires wiphy mutex anyway, better just convert it to a wiphy work. johannes