[PATCH v2 3/3] net: wireless: b43: Statics are init to 0
Michael Büsch <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <20151019181157.7018b25c@wiggum> |
On Mon, 19 Oct 2015 17:02:23 +0100 Paul McQuade <[email protected]> wrote: > diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c > index 058a9f2..086f0ba 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -2502,7 +2502,7 @@ static int lpphy_b2063_tune(struct b43_wldev *dev, > { > struct ssb_bus *bus = dev->dev->sdev->bus; > > - static const struct b206x_channel *chandata = NULL; > + static const struct b206x_channel *chandata; > u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000; > u32 freqref, vco_freq, val1, val2, val3, timeout, timeoutref, count; > u16 old_comm15, scale; Why on earth is this static anyway? That seems really wrong here. The static should be removed (and the =NULL init be left in place.) -- Michael -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20151019/5b6d1086/attachment-0001.sig>