[PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init
Michael Büsch <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <20160111172153.37a9613f@wiggum> |
On Mon, 11 Jan 2016 11:37:36 +0800 Jia-Ju Bai <[email protected]> wrote: > The memory allocated by kzalloc in b43_bus_dev_ssb_init is not freed. > This patch fixes the bug by adding kfree in b43_ssb_remove. > > Signed-off-by: Jia-Ju Bai <[email protected]> > --- > drivers/net/wireless/b43/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c > index ec013fb..6d251a0 100644 > --- a/drivers/net/wireless/b43/main.c > +++ b/drivers/net/wireless/b43/main.c > @@ -5798,6 +5798,7 @@ static void b43_ssb_remove(struct ssb_device *sdev) > > b43_leds_unregister(wl); > b43_wireless_exit(dev, wl); > + kfree(dev); > } > > static struct ssb_driver b43_ssb_driver = { Nice catch. The kfree is also missing in b43_bcma_remove(). And also in the error paths of b43_bcma_probe(). Can you please extend the patch to cover these, too? -- Michael -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20160111/4c48e701/attachment.sig>