[PATCH] b43: fix memory leak
Rafał Miłecki <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <CACna6rztbZ5P4RborXrTdLJDEmQyGNOExNvAmWcxZG83stS2bg@mail.gmail.com> |
On 18 February 2016 at 13:34, Sudip Mukherjee <[email protected]> wrote: > From: Sudip Mukherjee <[email protected]> > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and maybe use an additional label? Also may we be missing a proper free in b43_bcma_remove as well? Your patch subject could also be a bit more descriptive (e.g. what memory leak exactly is it).