[v2, resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init
Kalle Valo <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
Michael B?sch <[email protected]> writes: > On Fri, 11 Mar 2016 21:52:30 +0530 > Sudip Mukherjee <[email protected]> wrote: > >> On Sat, Jan 16, 2016 at 09:08:10PM +0800, Jia-Ju Bai wrote: >> > The memory allocated by kzalloc in b43_bus_dev_ssb_init and >> > b43_bus_dev_bcma_init is not freed. >> > This patch fixes the bug by adding kfree in b43_ssb_remove, >> > b43_bcma_remove and error handling code of b43_bcma_probe. >> > >> > Thanks Michael for his suggestion. >> > >> > Signed-off-by: Jia-Ju Bai <[email protected]> >> >> The patch did not apply cleanly. I had to edit the patch to point to >> drivers/net/wireless/broadcom/b43/main.c >> >> For CONFIG_B43_SSB part- >> Tested-by: Sudip Mukherjee <[email protected]> > > > Ok thanks a lot. > We possibly don't get an bcma tester anytime soon. As this is quite an > important fix, we should probably apply it. > > Sudip, can you please update the patch so it applies cleanly on the > current tree? You can add my acked-by if you want. > > Kalle, can you please apply it afterwards? Will do. -- Kalle Valo