[PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post
Larry Finger <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 12/30/2017 05:08 AM, Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai <[email protected]> checkpatch.pl reports the following warning for this patch: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt #26: FILE: drivers/net/wireless/broadcom/b43/phy_n.c:1034: + msleep(2); total: 0 errors, 1 warnings, 0 checks, 8 lines checked Have you tested to verify that a sleep as long as 20 ms will not cause problems? The referenced document suggests a usleep_range() call. In general, delay changes should never be proposed without testing. Larry