net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment
Kalle Valo <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Jia-Ju Bai <[email protected]> wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of INIT_WORK() in > b43legacy_wireless_init(). > > Despite never getting called from atomic context, > dma_tx_fragment() calls alloc_skb() with GFP_ATOMIC, > which does not sleep for allocation. > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, > which can sleep and improve the possibility of sucessful allocation. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <[email protected]> Patch applied to wireless-drivers-next.git, thanks. 6e1d8d1470b2 net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment -- https://patchwork.kernel.org/patch/10333217/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches