[PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage
Kees Cook <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,dev.linux.lists.drbd-dev,org.kernel.vger.linux-block,org.kernel.vger.linux-clk,org.kernel.vger.linux-doc,org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <202007020819.318824DA@keescook> |
On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings (e.g. > > "unused variable"). If the compiler thinks it is uninitialized, either > > simply initialize the variable or make compiler changes. As a precursor > > to removing[2] this[3] macro[4], just remove this variable since it was > > actually unused: > > Please copy maintainers on patches :( Hi! Sorry about that; the CC list was giant, so I had opted for using subsystem mailing lists where possible. > Acked-by: Mark Brown <[email protected]> Thanks! -- Kees Cook