Re: [PATCH v2] b43: don't save dentries for debugfs
Jeff Johnson <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 2021-05-18 09:33, Greg Kroah-Hartman wrote: > There is no need to keep around the dentry pointers for the debugfs > files as they will all be automatically removed when the subdir is > removed. So save the space and logic involved in keeping them around > by > just getting rid of them entirely. > > By doing this change, we remove one of the last in-kernel user that was > storing the result of debugfs_create_bool(), so that api can be cleaned > up. Question not about this specific change, but the general concept of keeping (or not keeping) dentry pointers. In the ath drivers, as well as in an out-of-tree driver for Android, we keep a debugfs dentry pointer to use as a param to relay_open(). Will we still be able to have a dentry pointer for this purpose? Or better, is there a recommended way to get a dentry pointer NOT associated with debugfs at all (which would be ideal for Android where debugfs is disabled). Thanks, Jeff -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ b43-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/b43-dev