Re: [PATCH] net: wireless/broadcom: fix possible condition with no effect
Sebastian Gottschall <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Am 25.06.2022 um 21:29 schrieb Praghadeesh T K S: > Fix a coccinelle warning by removing condition with no possible effect > > Signed-off-by: Praghadeesh T K S <[email protected]> > --- > drivers/net/wireless/broadcom/b43/xmit.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c > index 7651b1b..667a74b 100644 > --- a/drivers/net/wireless/broadcom/b43/xmit.c > +++ b/drivers/net/wireless/broadcom/b43/xmit.c > @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *dev, u8 bitrate) > const struct b43_phy *phy = &dev->phy; > const struct b43_tx_legacy_rate_phy_ctl_entry *e; > u16 control = 0; > - u16 bw; > - > - if (phy->type == B43_PHYTYPE_LP) > - bw = B43_TXH_PHY1_BW_20; > - else /* FIXME */ > - bw = B43_TXH_PHY1_BW_20; > + u16 bw = B43_TXH_PHY1_BW_20; Can you check if this is a possible register typo? > > if (0) { /* FIXME: MIMO */ > } else if (b43_is_cck_rate(bitrate) && phy->type != B43_PHYTYPE_LP) { _______________________________________________ b43-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/b43-dev