Re: [PATCH] wifi: b43: fix incorrect __packed annotation

"Arnd Bergmann" <[email protected]>
Newsgroups org.infradead.lists.b43-dev,dev.linux.lists.llvm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev
Message-ID <[email protected]>
On Tue, May 16, 2023, at 19:12, Michael Büsch wrote:
> On Tue, 16 May 2023 09:45:42 +0200
> Arnd Bergmann <[email protected]> wrote:
>
>> b43_iv { union {
>>  		__be16 d16;
>>  		__be32 d32;
>> -	} data __packed;
>> +	} __packed data;
>>  } __packed;
>>  
>>  
>
> Oh, interesting. This has probably been there forever.
> Did you check if the b43legacy driver has the same issue?

I had not checked, but I see that it does have the same bug.

I only sent this one because the build bot (incorrectly)
blamed one of my recent patches for a regression here.
Which reminds me that I was missing:

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Should I resend this as a combined patch for both drivers?

   Arnd

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.