Re: [PATCH] [v2] wifi: b43: fix incorrect __packed annotation
Kalle Valo <[email protected]>
| Newsgroups | org.infradead.lists.b43-dev,dev.linux.lists.llvm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Arnd Bergmann <[email protected]> wrote: > From: Arnd Bergmann <[email protected]> > > clang warns about an unpacked structure inside of a packed one: > > drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct b43_iv' is less aligned than 'union (unnamed union at /home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h:651:2)' and is usually due to 'struct b43_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] > > The problem here is that the anonymous union has the default alignment > from its members, apparently because the original author mixed up the > placement of the __packed attribute by placing it next to the struct > member rather than the union definition. As the struct itself is > also marked as __packed, there is no need to mark its members, so just > move the annotation to the inner type instead. > > As Michael noted, the same problem is present in b43legacy, so > change both at the same time. > > Acked-by: Michael Büsch <[email protected]> > Reported-by: kernel test robot <[email protected]> > Reviewed-by: Simon Horman <[email protected]> > Tested-by: Larry Finger <[email protected]> > Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/ > Signed-off-by: Arnd Bergmann <[email protected]> Patch applied to wireless.git, thanks. 212457ccbd60 wifi: b43: fix incorrect __packed annotation -- https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ b43-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/b43-dev