Re: [PATCH wireless v2 4/4] wifi: b43: Disable QoS for bcm4331
Julian Calaby <[email protected]> Mon, 1 Jan 2024 19:05:01 +1100
| Newsgroups | org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <CAGRGNgXYBM16UNcHmOVMJKa+C5R9-Hy7vamEBpp=cF_heQVX6Q@mail.gmail.com> |
Hi Rahul, On Sun, Dec 31, 2023 at 4:04 PM Rahul Rameshbabu <[email protected]> wrote: > > bcm4331 seems to not function correctly with QoS support. This may be due > to issues with currently available firmware or potentially a device > specific issue. > > When queues that are not of the default "best effort" priority are > selected, traffic appears to not transmit out of the hardware while no > errors are returned. This behavior is present among all the other priority > queues: video, voice, and background. While this can be worked around by > setting a kernel parameter, the default behavior is problematic for most > users and may be difficult to debug. This patch offers a working out-of-box > experience for bcm4331 users. > > [snip] > > Fixes: e6f5b934fba8 ("b43: Add QOS support") > Signed-off-by: Rahul Rameshbabu <[email protected]> LGTM Reviewed-by: Julian Calaby <[email protected]> Thanks, -- Julian Calaby Email: [email protected] Profile: http://www.google.com/profiles/julian.calaby/ _______________________________________________ b43-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/b43-dev