Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs_emit

"Zhijian Li (Fujitsu)" <[email protected]> Fri, 15 Mar 2024 01:16:07 +0000

Newsgroups	org.infradead.lists.b43-dev,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless
Message-ID	<[email protected]>


On 15/03/2024 02:32, Michael Büsch wrote:
> On Thu, 14 Mar 2024 17:48:22 +0800
> Li Zhijian <[email protected]> wrote:
> 
>>   	case B43legacy_INTERFMODE_NONE:
>> -		count = snprintf(buf, PAGE_SIZE, "0 (No Interference"
>> -				 " Mitigation)\n");
>> +		count = sysfs_emit(buf, "0 (No Interference" " Mitigation)\n");
>>   		break;
> 
>>   	if (wldev->short_preamble)
>> -		count = snprintf(buf, PAGE_SIZE, "1 (Short Preamble"
>> -				 " enabled)\n");
>> +		count = sysfs_emit(buf, "1 (Short Preamble" " enabled)\n");
>>   	else
>> -		count = snprintf(buf, PAGE_SIZE, "0 (Short Preamble"
>> -				 " disabled)\n");
>> +		count = sysfs_emit(buf, "0 (Short Preamble" " disabled)\n");
>>   
> 
> Please either leave the line break in place, or remove the string continuation.

Good catch, i will update it.


Thanks
Zhijian

> 
> 
> 
_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev