Re: [PATCH 0/6] b43: complete N-PHY rev 8 + radio 2057 rev 8 support

--===============5438485769883731946==
Content-Type: multipart/signed; boundary="Sig_/Ya/n0a=Cznl2sfj19DrTnxn";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/Ya/n0a=Cznl2sfj19DrTnxn
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 19 May 2026 15:32:44 -0400
"Joshua Peisach" <[email protected]> wrote:

> On Tue May 19, 2026 at 11:58 AM EDT, Michael B=C3=BCsch wrote:
> > On Mon, 18 May 2026 03:49:33 +0200
> > Alessio Ferri <[email protected]> wrote:
> >
> > In general this looks Ok.
> > From the style I assume that this is AI generated, right?
> > If so, can you tell us a bit more about the inputs used for the AI?
> > What information is this implementation based on? =20
>=20
> So... awkward question.

Why?

> Wasn't there just a conversation[1] about the
> future development of this module, that was left off at "don't touch it
> unless you're going to thouroughly test this",

Sure. That's why I ask about the development methods used.

> and now we are going to have a *LLM* work on this?

I don't care whether code was generated with an LLM or not.
What matters is the development methods used.

Changed must be based on actual correct knowledge (e.g. reverse engineering=
).
Just asking an LLM to do the change without putting that knowledge in is no=
t Ok.
Changes must be tested.
Changes must have a real benefit.
Changes should be low risk, if they can't be tested on all hardware right a=
way.
etc. etc.

Most of this patch set looks to be low risk, because it only seems to
touch code paths for core revisions that were previously unimplemented.

But I'm unsure and I can't remember all the details.
This is why I asked about the development methods used.

What would be Ok? Using an LLM to generate a fully functional and well
tested change from reverse engineered information.

What would not be Ok? Asking an LLM to change the driver just for the
sake of changing it or "cleaning it up". Or using an LLM to make
changes from hallucinated "specifications".


Btw, this looks to be the corresponding tool PR for this change, I guess:
https://github.com/mbuesch/b43-tools/pull/10


--=20
Michael B=C3=BCsch
https://bues.ch/

--Sig_/Ya/n0a=Cznl2sfj19DrTnxn
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAmoMv4wACgkQ9TK+HZCN
iw4jxw/9GPRSy1mZMFxtuXiNqDXvCTIVzH3YEOZpxcEar3RDEbpLzIzTmpiaqEq+
7E1fo4a4VeV7RYt1BqmjpOcPy0R16Ge2UbGcLQ6uw6AF3J1zqJ6Cy2PhhY1MIk5B
4ddWuJ6zioMy15ZCy3n8OhakOek7+JRvgSX7dQdYX0ydV4o1sPHcEH6ZM2sgLcLo
Du7p5M7XWzQgge1gf4nDTwlA+IMYrtaYFWROVFf7j2MmeAULlNmVrv/bwgwWJapU
rsQG/vOUg5h2Eh/hw+Iy0F7rgk17Xe19BODAF7DONeQk9NB+ujWsLYV8B2ueZf4i
cdTvnpUmuLMc/A7vGRzsbTmRFaGqiUersjJTexWaum4Q1odd8TOCYNhePDeZz0P8
rGwDE2BBqalQIYwoE3DltvdAD9GIB6vc9ZeUQheu389Qa6paPEKMiw5+EYa14QsD
iIeb5qZGdoWrrzflCd2+30+m9EqgFjjc519XpzGSIIhYwjlGGFIWC0pqFTJTvhxZ
DRaG84Q6imtf9psmXJIcGgAonzZB0dYpN7JlNLdrZg0ylyB4r0LA+vp+vo3REpql
kRxTT7grFRXQbUTZl+Sfg0WckkTpS262wzpyuNhhbwtzSyJlO3myISP0XJ7MZF4i
2kLwbOBo8QQ1uHTxyvg9Vyz9BfoIEIKYomVOAH1qtNPuQUEPQdc=
=+7RV
-----END PGP SIGNATURE-----

--Sig_/Ya/n0a=Cznl2sfj19DrTnxn--


--===============5438485769883731946==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev

--===============5438485769883731946==--