Re: [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()

Hi Alexander,

On 2026-05-28 15:15, Alexander Shiyan wrote:
> From: Miaoqian Lin <[email protected]>
> 
> Replace NULL check with IS_ERR_OR_NULL() check after calling
> rockchip_clk_register_gate_link() since this function
> returns error pointers (ERR_PTR).
> 
> Fixes: c62fa612cfa6 ("clk: rockchip: implement linked gate clock support")
> Signed-off-by: Miaoqian Lin <[email protected]>
> Link: https://patch.msgid.link/[email protected]
> Signed-off-by: Heiko Stuebner <[email protected]>
> Signed-off-by: Alexander Shiyan <[email protected]>
> ---
>  drivers/clk/rockchip/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

BTW better quote the whole Linux commit message including the tags and
make yourself the author of the patch. The original Linux commit authors
and reviewers are likely not interested in that the patch is merged in
barebox. Also when the original patch carries a reviewed-by: tag this
is only valid in the Linux context, not in barebox.

Sascha


> 
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index 987c3bc518..d01574c60b 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -566,7 +566,7 @@ void rockchip_clk_register_late_branches(struct device *dev,
>  			break;
>  		}
>  
> -		if (!pdev)
> +		if (IS_ERR_OR_NULL(pdev))
>  			dev_err(dev, "failed to register device for clock %s\n", list->name);
>  	}
>  }
> -- 
> 2.52.0
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |