[PATCH master 1/3] efi: gop: fix rectangle extents passed to fb_damage
Ahmad Fatoum <[email protected]> Sat, 27 Jun 2026 11:55:39 +0200
| Newsgroups | org.infradead.lists.barebox |
|---|---|
| Message-ID | <[email protected]> |
fb_damage takes the coordinates of the upper left and bottom right
pixels as can be seen in fb_rect_width() and fb_rect_height().
We erroneously passed only width and height though, so add the origin
pixel coordinates on top to fix this.
Fixes: d040f49ad0b3 ("efi: loader: protocol: add graphical output protocol support")
Signed-off-by: Ahmad Fatoum <[email protected]>
---
efi/loader/protocols/gop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/efi/loader/protocols/gop.c b/efi/loader/protocols/gop.c
index 9ada8a2da290..d48edac5a2d6 100644
--- a/efi/loader/protocols/gop.c
+++ b/efi/loader/protocols/gop.c
@@ -248,7 +248,7 @@ static __always_inline efi_status_t gop_blt_int(struct efi_graphics_output_proto
}
if (blt_to_video) {
- struct fb_rect rect = { dx, dy, width, height };
+ struct fb_rect rect = { dx, dy, dx + width, dy + height };
fb_damage(gopobj->fbi, &rect);
}
--
2.47.3