Re: [PATCH v3 08/15] usb: ehci: initialize periodic_queue_dma

On 2026-08-02 15:16, Luca Lauro via B4 Relay wrote:
> From: Luca Lauro <[email protected]>
>=20
> Store the DMA address of the periodic queue head in
> ehci->periodic_queue_dma. Without this initialization the periodic
> schedule may reference an invalid address.
>=20
> Signed-off-by: Luca Lauro <[email protected]>
> ---
>  drivers/usb/host/ehci-hcd.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 51b9e52a4f..a4832bb3ff 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -897,6 +897,8 @@ static int ehci_init(struct usb_host *host)
>  	periodic->qt_next =3D cpu_to_hc32(QT_NEXT_TERMINATE);
>  	periodic->qt_altnext =3D cpu_to_hc32(QT_NEXT_TERMINATE);
> =20
> +	ehci->periodic_queue_dma =3D ehci_qh_dma(ehci, periodic);
> +
>  	/*
>  	 * Step 2: Setup frame-list: Every microframe, USB tries the same list.
>  	 *         In particular, device specifications on polling frequency
> @@ -1442,11 +1444,14 @@ static int ehci_probe(struct device *dev)
>  	if (ret)
>  		return ret;
> =20
> -	ret =3D clk_bulk_get_all_enabled(dev, &clks);
> +	ret =3D clk_bulk_get_all(dev, &clks);
>  	if (ret < 0)
>  		return ret;
> =20
>  	num_clocks =3D ret;
> +	ret =3D clk_bulk_enable(num_clocks, clks);
> +	if (ret)
> +		return ret;

This looks unrelated to this patch. Does this change make any
difference?

Sascha

--
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |