Re: [PATCH 0/3] mm: split a couple of headers from internal.h

> On Jul 9, 2026, at 15:22, Mike Rapoport <[email protected]> wrote:
> 
> On Thu, Jul 09, 2026 at 09:41:46AM +0300, Mike Rapoport (Microsoft) wrote:
>> mm/internal.h becomes more and more bloated.
>> 
>> Split declarations related to mm_init, memblock, vmalloc and sparse into
>> new headers.
> 
> Sashiko rightfully pointed to some issues, will send v2 later.

Hi Mike,

I recall that this work was mentioned during the last review in my series.
However, I didn't have time to address it then because I was still working
on the HVO refactoring. I really appreciate you taking this on. Thanks for
your work.

I've reviewed Sashiko's comments as well, and it doesn't look like there are
any major issues. Therefore, feel free to add my ack for this whole series
in your v2 version with the proper fix.

Acked-by: Muchun Song <[email protected]>

Muchun,
Thanks

> 
>> ---
>> Mike Rapoport (Microsoft) (3):
>>      mm: split out mm_init and memblock declarations from internal.h
>>      mm: split out sparse declarations from internal.h
>>      mm: split out vmalloc declarations from internal.h
>> 
>> MAINTAINERS                        |   3 +
>> kernel/liveupdate/kexec_handover.c |   3 +-
>> mm/cma.c                           |   1 +
>> mm/execmem.c                       |   1 +
>> mm/hugetlb.c                       |   1 +
>> mm/internal.h                      | 183 -------------------------------------
>> mm/kmsan/hooks.c                   |   1 +
>> mm/kmsan/shadow.c                  |   1 +
>> mm/memblock.c                      |   1 +
>> mm/memory_hotplug.c                |   1 +
>> mm/mm_init.c                       |   3 +
>> mm/mm_init.h                       | 120 ++++++++++++++++++++++++
>> mm/page_alloc.c                    |   1 +
>> mm/percpu-vm.c                     |   1 +
>> mm/sparse-vmemmap.c                |   2 +
>> mm/sparse.c                        |   2 +
>> mm/sparse.h                        |  63 +++++++++++++
>> mm/vmalloc.c                       |   1 +
>> mm/vmalloc.h                       |  46 ++++++++++
>> 19 files changed, 251 insertions(+), 184 deletions(-)
>> ---
>> base-commit: 820d5dfede0cd55dcbc89ce96fcfbb11b7c457ba
>> change-id: 20260707-internal-h-2efef660381d
>> 
>> --
>> Sincerely yours,
>> Mike.
>> 
> 
> -- 
> Sincerely yours,
> Mike.