Re: [PATCH 02/10] util_lib: Add vmcoreinfo parser and memory reader

Simon Horman <[email protected]> Mon, 20 Jul 2026 10:24:48 +0100
Newsgroups org.infradead.lists.kexec
Message-ID <[email protected]>
On Mon, Jun 22, 2026 at 11:54:40PM +0300, Pnina Feder wrote:
> Add the foundational utility libraries for parsing vmcore files:
> 
> - vmcore_info: Parser for vmcoreinfo note section. Supports SYMBOL(),
>   OFFSET(), SIZE(), NUMBER(), LENGTH() lookups via hash table.
>   Provides cached get_page_size()/get_page_shift() accessors.
>   Handles plain KEY=VALUE entries like PAGESIZE and OSRELEASE.
> 
> - memory: Virtual-to-physical address translation dispatcher and
>   readmem() for reading from vmcore via kernel or user virtual
>   addresses, or physical addresses.Uses paddr_to_offset() from
>   elf_info for physical-to-file-offset mapping.
> 
> - vmcore_tasks_util: Shared macros, typedefs, and debug helpers
>   used by vmcore_info and memory (debug verbosity levels, type
>   accessors, __weak definition).
> 
> These files are placed in util_lib/ but are currently only built by
> the vmcore_tasks Makefile. Integration into the main util_lib build
> can be done later if other tools need them.
> 
> Signed-off-by: Pnina Feder <[email protected]>

There are whitepsace errors when applying using git am.
Likewise in patch 5/10, 8/10 and 9/10.

I'd appreciate it if you could address that along with
the minor concerns I raised with patch 1/10.

...