Re: [GIT PULL] liveupdate: a fix for v7.2-rc5

On Wed, 22 Jul 2026 at 09:25, Mike Rapoport <[email protected]> wrote:
>
> * Fix validation of LIVEUPDATE_SESSION_GET_NAME ioctl argument caused by a
>   wrong resolution of a merge conflict during the last merge window

Hmm. I tried to figure this one out, and there's no "Fixes" tag on this commit.

It would seem to appear that the "merge conflict" wasn't actually a
merge conflict, it was in fact a bad rebase (which in turn was due to
a merge conflict in linux-next).

People really should be extra careful about rebases like this. They
destroy history, and when bugs happen, it's really hard to see *why*
the bug happened because the actual cause of the bug has disappeared
and no longer exists after the rebase.

I *think* this commit should have a

   Fixes: 507e3b479f9c ("liveupdate: validate session type before
performing operation")

but I'm not familiar with this code, so somebody should check that.

I really would like to see "Fixes" tags in general - but
*particularly* for something like this because it's marked for stable
(apparently because the bad rebase was marked for stable).

             Linus