Re: [PATCH v4 19/21] memblock: make HugeTLB bootmem allocation work with KHO
Pratyush Yadav <[email protected]> Wed, 29 Jul 2026 16:20:01 +0200
| Newsgroups | org.infradead.lists.kexec,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 28 2026, Mike Rapoport wrote: > On Sat, Jul 25, 2026 at 07:21:19PM +0200, Pratyush Yadav wrote: >> >> diff --git a/mm/memblock.c b/mm/memblock.c >> index 8b2e551435ae..ff470fd0fd10 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -19,11 +19,9 @@ >> #include <linux/mutex.h> >> #include <linux/string_helpers.h> >> >> -#ifdef CONFIG_KEXEC_HANDOVER >> #include <linux/libfdt.h> >> #include <linux/kexec_handover.h> >> #include <linux/kho/abi/memblock.h> >> -#endif /* CONFIG_KEXEC_HANDOVER */ > > This breaks memblock tests, can you please add stubs for these in > tools/testing/memblock? I swear I tried building memblock tests but somehow still missed this :-(. I think it is because the very last thing I tested was a boot with KHO disabled, and that's when I discovered this. Anyway, will fix in next version. -- Regards, Pratyush Yadav