Re: [PATCH v3 07/17] riscv: Maintain epc on misaligned emulation error
Damien Le Moal <[email protected]>
| Newsgroups | org.infradead.lists.kvm-riscv,org.infradead.lists.linux-riscv,org.kernel.vger.kvm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 2026/08/06 1:38, Nam Cao wrote: > Charlie Jenkins <[email protected]> writes: >> Currently the epc is set to zero when there is a misaligned emulation >> error. This will print a misleading error message with the current epc >> value of zero instead of the epc value that triggered the emulation. >> Avoid setting epc to zero to maintain the state of epc. >> >> Signed-off-by: Charlie Jenkins <[email protected]> > > I see no reason why epc must be set to zero, so: > Reviewed-by: Nam Cao <[email protected]> > > But to be sure, I add to CC: Damien Le Moal <[email protected]> > > Damien, any reason that epc must be cleared? It has been a while since I touched this, and frankly, I do not remember at all. As the original commit 956d705dd279f says: Code heavily inspired from the OpenSBI project. So I may have copied this without thinking too much. That's likely Anup's code, so maybe Anup can weight in here. -- Damien Le Moal Western Digital Research -- kvm-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kvm-riscv