Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The commit introduces a spurious `depends on MESON_SM` dependency for `CONFIG_AMLOGIC_THERMAL` based on the false premise that the driver calls `meson_sm_get()` and `meson_sm_get_thermal_calib()`. An analysis of `drivers/thermal/amlogic_thermal.c` confirms it relies on a syscon regmap (`amlogic,ao-secure`) for its calibration data and makes no calls to the secure monitor driver. Crucially, `MESON_SM` strictly depends on `ARM64_4K_PAGES`. Thus, this patch inadvertently disables thermal management on all Amlogic systems using 16K or 64K page sizes, or those intentionally omitting `MESON_SM`.
--
commit f9c3b9097ac770542e726a379a07047abb369bae
Author: Ronald Claveau <[email protected]>
thermal: amlogic: add missing dependency on MESON_SM
This commit adds a dependency on MESON_SM to the Amlogic thermal driver
configuration to address reported undefined references.
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -436,6 +436,7 @@ config AMLOGIC_THERMAL
> tristate "Amlogic Thermal Support"
> default ARCH_MESON
> depends on OF && ARCH_MESON
> + depends on MESON_SM
[Severity: High]
The commit message states that the amlogic thermal driver calls
meson_sm_get() and meson_sm_get_thermal_calib(). Is this description
accurate?
Looking at drivers/thermal/amlogic_thermal.c, the driver appears to rely on a
syscon regmap (amlogic,ao-secure) for its calibration data, rather than making
direct calls to the secure monitor.
Since MESON_SM has a strict dependency on ARM64_4K_PAGES, wouldn't adding
this dependency inadvertently disable thermal management on all Amlogic
systems using 16K or 64K page sizes, or those intentionally omitting MESON_SM?
Without thermal management, these systems might suffer from a lack of
active cooling or thermal throttling.
> help
> If you say yes here you get support for Amlogic Thermal
> for G12 SoC Family.
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.