Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM

On 6/2/26 16:19, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <[email protected]>
> 
> The amlogic thermal driver calls meson_sm_get() and
> meson_sm_get_thermal_calib() which are exported by the meson_sm
> driver. Without CONFIG_MESON_SM enabled, the build fails with
> undefined references to these symbols.
> 
> Add a proper Kconfig dependency on MESON_SM instead of relying on
> stub functions, which makes the dependency explicit and prevents
> invalid configurations.
> 
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Reported-by: Mark Brown <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Ronald Claveau <[email protected]>
> ---
> Changes in v3:
> - Add a dependency on MESON_SM instead of stub functions.
> - Link to v2: https://lore.kernel.org/r/[email protected]
> 
> Changes in v2:
> - Replace #ifdef CONFIG_MESON_SM by #if IS_ENABLED(CONFIG_MESON_SM)
>    to cover builtin and module in config.
> - Add missing trailers for kernel test robot.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
>   drivers/thermal/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 1c4a5cd5a23ee..810eeccedfbab 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -436,6 +436,7 @@ config AMLOGIC_THERMAL
>   	tristate "Amlogic Thermal Support"
>   	default ARCH_MESON
>   	depends on OF && ARCH_MESON
> +	depends on MESON_SM
>   	help
>   	  If you say yes here you get support for Amlogic Thermal
>   	  for G12 SoC Family.

Did you forget to remove the stubs ?

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic