Re: [PATCH 07/14] pinctrl: Kconfig: drop unneeded dependencies on OF_GPIO
Timur Tabi <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,dev.linux.lists.linux-staging,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-snps-arc,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-pm,org.kernel.vger.linux-watchdog,org.kernel.vger.netdev,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <CAOZdJXXetr-FPZUSX_nzS5nZc+bbv5b1m78sCcZzrDJi7C05vw@mail.gmail.com> |
On Wed, Mar 4, 2026 at 3:07 AM Bartosz Golaszewski <[email protected]> wrote: > > @@ -557,7 +549,6 @@ config PINCTRL_ST > config PINCTRL_STMFX > tristate "STMicroelectronics STMFX GPIO expander pinctrl driver" > depends on I2C > - depends on OF_GPIO > depends on HAS_IOMEM > select GENERIC_PINCONF > select GPIOLIB_IRQCHIP This change causes the following warning on builds: WARNING: unmet direct dependencies detected for MFD_STMFX Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n] Selected by [m]: - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y] WARNING: unmet direct dependencies detected for MFD_STMFX Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n] Selected by [m]: - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y] I believe the proper fix is to have PINCTRL_STMFX depend on CONFIG_OF, since this driver actually does depend on CONFIG_OF. The warning comes because if CONFIG_OF is disabled, PINCTRL_STMFX can still be enabled, but in doing so it selects MFD_STMFX which does depend on CONFIG_OF. Adding "depends on OF" to "config PINCTRL_STMFX" seems to fix the problem, but I'm not familiar with this driver so I'm not sure this is the right fix. I'll post a patch. _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic