Re: [PATCH v4 8/8] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events
Dmitry Baryshkov <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,dev.linux.lists.sashiko-reviews,org.freedesktop.lists.dri-devel |
|---|---|
| Message-ID | <qvxtodvp6zqeohrb36kjxrglkk4rx3gohrx7uvz2x7zm5fxlyp@t7d25j2pm6le> |
On Sun, Jun 07, 2026 at 09:46:21PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: > > Pre-existing issues: > - [High] Early return misses EC hardware acknowledgement, potentially causing an interrupt storm. > - [High] Deadlock between EC threaded IRQ handler and UCSI notifier causing inevitable timeout. > - [High] Out-of-bounds array access due to dynamic `num_ports` update surpassing allocated size. > - [Medium] Undefined Behavior due to shift operation with negative exponent. > -- Pengyu Luo, is this something that is worth fixing? I don't have the hw, so I can't check... -- With best wishes Dmitry _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic