Re: [PATCH v4 1/8] drm/connector: report out-of-band IRQ_HPD events
Maxime Ripard <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.freedesktop.lists.intel-xe,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <20260609-bouncy-tomato-dalmatian-70ccee@houat> |
Hi, On Mon, Jun 08, 2026 at 12:33:02AM +0300, Dmitry Baryshkov wrote: > The DisplayPort standard defines a special kind of events called IRQ. > These events are used to notify DP Source about the events on the Sink > side. It is extremely important for DP MST handling, where the MST > events are reported through this IRQ. > > In case of the USB-C DP AltMode there is no actual HPD pulse, but the > events are reported through the bits in the AltMode VDOs. > > Rename drm_connector_oob_hotplug_event() to drm_connector_dp_oob_status() > and extend its interface to report IRQ events to the DisplayPort Sink > drivers. > > Acked-by: Heikki Krogerus <[email protected]> > Signed-off-by: Dmitry Baryshkov <[email protected]> > --- > drivers/gpu/drm/drm_connector.c | 20 ++++++++++++-------- > drivers/usb/typec/altmodes/displayport.c | 23 +++++++++++++++-------- > include/drm/drm_connector.h | 21 +++++++++++++++++++-- > 3 files changed, 46 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 3fa4d2082cd7..bb128dd0263a 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -3502,20 +3502,24 @@ struct drm_connector *drm_connector_find_by_fwnode(struct fwnode_handle *fwnode) > } > > /** > - * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector > + * drm_connector_dp_oob_status - Report out-of-band hotplug event to DisplayPort connector > * @connector_fwnode: fwnode_handle to report the event on > * @status: hot plug detect logical state > + * @extra_status: additional information provided by the sink without changing > + * the HPD state (or in addition to such a change). > * > - * On some hardware a hotplug event notification may come from outside the display > - * driver / device. An example of this is some USB Type-C setups where the hardware > - * muxes the DisplayPort data and aux-lines but does not pass the altmode HPD > - * status bit to the GPU's DP HPD pin. > + * In some cases when DisplayPort signals are being routed through the USB > + * Type-C port the hotplug event notifications come from outside of the display > + * driver / device. In this case hardware muxes the DisplayPort data and > + * AUX-lines but does not pass the altmode HPD status bit to the GPU's DP HPD > + * pin. > * > * This function can be used to report these out-of-band events after obtaining > * a drm_connector reference through calling drm_connector_find_by_fwnode(). > */ > -void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, > - enum drm_connector_status status) > +void drm_connector_dp_oob_status(struct fwnode_handle *connector_fwnode, > + enum drm_connector_status status, > + enum drm_connector_status_extra extra_status) Thanks for the renaming, but I think we can also rename drm_connector_status_extra to something a bit more descriptive now? drm_connector_dp_oob_event? status? The rest looks good. Maxime _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic
signature.asc
(application/pgp-signature, 273 B)
-----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaigTAQAKCRAnX84Zoj2+ dnv2AX9le3hz+Lu8gxYvgEXc1sDIBCPM1bh/zkVwBN3wZ9THVMA3l8RMscsHED+I ZdjXquUBeQESub4sfU2kH0nggZa7VB2wC1SqcPxTrCSdEwKVl5n4RlSMJ/F47hOK i6kZa+CMlQ== =wSKV -----END PGP SIGNATURE-----