Re: [PATCH v3 2/2] clk: amlogic: Add A9 peripherals clock controller driver

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added Kconfig symbol `COMMON_CLK_A9_PERIPHERALS` implies a non-existent config symbol `COMMON_CLK_A9_PLL`.
--

commit 01c948d65d7fdd0d90013ab36dfe236bd635347c
Author: Jian Hu <[email protected]>

clk: amlogic: Add A9 peripherals clock controller driver

This commit adds the peripherals clock controller driver for the Amlogic A9 
SoC family. It introduces the COMMON_CLK_A9_PERIPHERALS Kconfig symbol and 
the corresponding driver source.

> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -132,6 +132,21 @@ config COMMON_CLK_A1_PERIPHERALS
>  	  device, A1 SoC Family. Say Y if you want A1 Peripherals clock
>  	  controller to work.
>  
> +config COMMON_CLK_A9_PERIPHERALS
> +	tristate "Amlogic A9 SoC peripherals clock controller support"
> +	depends on ARM64 || COMPILE_TEST
> +	default ARCH_MESON
> +	select COMMON_CLK_MESON_REGMAP
> +	select COMMON_CLK_MESON_CLKC_UTILS
> +	select COMMON_CLK_MESON_DUALDIV
> +	select COMMON_CLK_MESON_VID_PLL_DIV
> +	imply COMMON_CLK_SCMI
> +	imply COMMON_CLK_A9_PLL

[Severity: Medium]
Does the COMMON_CLK_A9_PLL config symbol exist? 

Looking through the Kconfig files, there doesn't appear to be a definition 
for COMMON_CLK_A9_PLL anywhere in the tree. While an unresolved imply doesn't
cause a hard build failure like select or depends on, it has no effect and
might indicate a missing PLL driver in this patch series or a typo in the 
symbol name.

> +	help
> +	  Support for the peripherals clock controller on Amlogic A311Y3 based
> +	  device, AKA A9. Peripherals are required by most peripheral to operate.
> +	  Say Y if you want A9 peripherals clock controller to work.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic