Re: [PATCH v3 3/3] arm64: dts: amlogic: meson-axg: Disable pcie_phy node by default

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Enabling `pcie_phy` on `meson-axg-s400.dts` is insufficient to support PCIe functionality because its hardware dependency `mipi_pcie_analog_dphy` remains disabled.
--

commit cd94d06969e9f9a23ea319f406b8e86e8ed9ec44
Author: Jun Yan <[email protected]>

arm64: dts: amlogic: meson-axg: Disable pcie_phy node by default

This patch disables the pcie_phy node by default in the meson-axg dtsi file
to suppress deferred probe warnings on boards that do not use it. It then
explicitly enables pcie_phy in the meson-axg-s400 board device tree to
preserve its PCIe functionality.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 285c6ac1dd613..7ba249cc3d569 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts

[ ... ]

> @@ -448,6 +448,10 @@ &pcieB {
>  	status = "okay";
>  };
>  
> +&pcie_phy {
> +	status = "okay";
> +};

[Severity: High]
This is a pre-existing issue, but is it sufficient to only enable pcie_phy
to restore PCIe functionality on the s400 board?

The pcie_phy node depends on the mipi_pcie_analog_dphy analog PHY via its
phys property. Looking at meson-axg.dtsi, mipi_pcie_analog_dphy is disabled
by default:

arch/arm64/boot/dts/amlogic/meson-axg.dtsi:
    mipi_pcie_analog_dphy: phy {
        compatible = "amlogic,axg-mipi-pcie-analog-phy";
        #phy-cells = <0>;
        status = "disabled";
    };

If the analog PHY is not also overridden to "okay" here in meson-axg-s400.dts,
will the analog PHY driver fail to probe, causing devm_phy_get(dev, "analog")
in the pcie_phy driver to continually return -EPROBE_DEFER?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic