Re: [PATCH v2 1/2] gpio: shared-proxy: always serialize with a sleeping mutex
Viacheslav <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi! 29.06.2026 20:06, Bartosz Golaszewski wrote: > On Thu, 25 Jun 2026 13:57:17 +0200, Viacheslav Bocharov <[email protected]> said: >> The shared GPIO descriptor used either a mutex or a spinlock, chosen at >> runtime from the underlying chip's can_sleep: >> ... snip ... >> >> @@ -32,7 +34,7 @@ gpio_shared_proxy_set_unlocked(struct gpio_shared_proxy_data *proxy, > > I was about to apply it but then realized that it can be simplified further. > The set_func() argument in gpio_shared_proxy_set_unlocked() is no longer > needed and can be replaced with a direct call to gpiod_set_value_cansleep(). Good catch! This would even remove the extra fuss with the GPIO state. > Would you mind sending a v3 with that included? Yes, I'll prepare the updates and send v3. > > Thanks, > Bartosz Best regards, Viacheslav _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic