Re: [PATCH v6 2/2] clk: amlogic: Add A9 peripherals clock controller driver
Jian Hu <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/1/2026 11:41 PM, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > On mer. 01 juil. 2026 at 16:30, Jian Hu via B4 Relay <[email protected]> wrote: > >> From: Jian Hu <[email protected]> >> >> Add the peripherals clock controller driver for the Amlogic A9 SoC family. >> >> Signed-off-by: Jian Hu <[email protected]> >> --- >> drivers/clk/meson/Kconfig | 15 + >> drivers/clk/meson/Makefile | 1 + >> drivers/clk/meson/a9-peripherals.c | 2089 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 2105 insertions(+) >> >> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig >> index b71299898197..5152868e2ee6 100644 >> --- a/drivers/clk/meson/Kconfig >> +++ b/drivers/clk/meson/Kconfig >> @@ -132,6 +132,21 @@ config COMMON_CLK_A1_PERIPHERALS >> device, A1 SoC Family. Say Y if you want A1 Peripherals clock >> controller to work. >> >> +config COMMON_CLK_A9_PERIPHERALS >> + tristate "Amlogic A9 SoC peripherals clock controller support" >> + depends on ARM64 || COMPILE_TEST >> + default ARCH_MESON >> + select COMMON_CLK_MESON_REGMAP >> + select COMMON_CLK_MESON_CLKC_UTILS >> + select COMMON_CLK_MESON_DUALDIV >> + select COMMON_CLK_MESON_VID_PLL_DIV >> + imply COMMON_CLK_SCMI >> + imply COMMON_CLK_A9_PLL > As mentioned by Sashiko, This is problematic because the symbol does > exist yet. This should be removed for now. It can be added back when > support for the PLL controllers is added > > I'm otherwise happy with this version. > If it is ok with you, I'll apply it with the line above removed. > Yes, that's fine with me. Please remove the 'imply COMMON_CLK_A9_PLL' line when applying. Thanks for your review. [ ... ] > -- > Jerome -- Jian _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic