Re: [PATCH 2/2] ASoC: meson: aiu-formatter: remove pipeline reset from prepare
Jerome Brunet <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On jeu. 02 juil. 2026 at 12:56, Valerio Setti <[email protected]> wrote: > 'aiu-formatter-i2s' already performs the very same reset in > 'aiu_fifo_i2s_trigger' for all relevant trigger scenarios. There is no > need to duplicate the operation in the formatter. > > Signed-off-by: Valerio Setti <[email protected]> Reviewed-by: Jerome Brunet <[email protected]> > --- > sound/soc/meson/aiu-formatter-i2s.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/meson/aiu-formatter-i2s.c b/sound/soc/meson/aiu-formatter-i2s.c > index b4604734fe88..cb554c2e7ce4 100644 > --- a/sound/soc/meson/aiu-formatter-i2s.c > +++ b/sound/soc/meson/aiu-formatter-i2s.c > @@ -13,7 +13,6 @@ > #define AIU_I2S_SOURCE_DESC_MODE_8CH BIT(0) > #define AIU_I2S_SOURCE_DESC_MODE_24BIT BIT(5) > #define AIU_I2S_SOURCE_DESC_MODE_32BIT BIT(9) > -#define AIU_RST_SOFT_I2S_FAST BIT(0) > > #define AIU_I2S_DAC_CFG_MSB_FIRST BIT(2) > > @@ -55,11 +54,11 @@ static int aiu_formatter_i2s_prepare(struct regmap *map, > { > /* Always operate in split (classic interleaved) mode */ > unsigned int desc = 0; > - unsigned int tmp; > > - /* Reset required to update the pipeline */ > - regmap_write(map, AIU_RST_SOFT, AIU_RST_SOFT_I2S_FAST); > - regmap_read(map, AIU_I2S_SYNC, &tmp); > + /* > + * Pipeline reset is already implemented in aiu_fifo_i2s_trigger() at > + * trigger time. > + */ > > switch (ts->physical_width) { > case 16: /* Nothing to do */ -- Jerome _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic