Re: [PATCH net-next v12 3/7] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems
| Newsgroups | org.infradead.lists.linux-amlogic,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The device tree bindings for Nuvoton MA35D1 and Spacemit K3 DWMAC were not updated to restrict `power-domains` to `maxItems: 1`, contradicting the commit message claim and inadvertently relaxing their constraints. -- commit 172a7357589e2c110ace7edfdec50dee477c4a83 Author: Bartosz Golaszewski <[email protected]> dt-bindings: net: qcom: document the ethqos device for SCMI-based systems This patch describes the firmware-managed variant of the QCom DesignWare MAC. It introduces the qcom,sa8255p-ethqos binding and increases the power-domains maximum to 2 in the top-level snps,dwmac.yaml schema, while updating existing referencing bindings to limit their power-domains maxItems back to 1. > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 2449311c6d28e..d3aff1df3070d 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml [ ... ] > @@ -185,7 +186,8 @@ properties: > - const: ahb > > power-domains: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 [Severity: Medium] The commit message states that existing bindings referencing the top-level snps,dwmac.yaml were updated to limit their maxItems for power-domains to 1. Were Nuvoton MA35D1 (nuvoton,ma35d1-dwmac.yaml) and Spacemit K3 (spacemit,k3-dwmac.yaml) missed during this refactoring? Since both of those schemas inherit from snps,dwmac.yaml, they will now inadvertently inherit the relaxed maxItems: 2 constraint, allowing invalid configurations to pass validation. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3 _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic