Re: [PATCH net-next v12 1/7] dt-bindings: phy: document the serdes PHY on sa8255p

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `power-domain-names` property lacks a string value constraint, allowing arbitrary strings to pass validation.
--

commit da2d01b0c5abee156fdc9bf1e261e5789a2c6fb7
Author: Bartosz Golaszewski <[email protected]>

dt-bindings: phy: document the serdes PHY on sa8255p

Describe the SGMII/SerDes PHY present on the Qualcomm sa8255p platforms.
This is essentially the same hardware as sa8775p rev3 but the PHY is
managed by firmware over SCMI.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8255p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8255p-dwmac-sgmii-phy.yaml
> new file mode 100644
> index 0000000000000..9e846e3815555
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8255p-dwmac-sgmii-phy.yaml
[ ... ]
> +  power-domains:
> +    maxItems: 1
> +
> +  power-domain-names:
> +    maxItems: 1

[Severity: Low]
Does this property need a string value constraint? 

The current schema limits the array length but allows arbitrary strings to pass
schema validation. Should it include an items list with a const value, such as
const: serdes, to match the usage in the example?

> +
> +  "#phy-cells":
> +    const: 0

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic