Re: [PATCH 2/2] arm64: dts: amlogic: a9: Add IR controller support
Martin Blumenstingl <[email protected]>
| Newsgroups | org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <CAFBinCBQ+g8Kr2tL9ob9PvTakGrtwH3qZWjEy-ytGiufGUEieg@mail.gmail.com> |
On Wed, Jul 8, 2026 at 4:39 AM Xianwei Zhao <[email protected]> wrote: > > Hi Martin, > Thanks for your review. > > On 2026/7/8 03:33, Martin Blumenstingl wrote: > > Hi Xianwei Zhao, > > > > On Mon, Jul 6, 2026 at 4:43 AM Xianwei Zhao via B4 Relay > > <[email protected]> wrote: > > [...] > >> + func-ir-in { > >> + remote_pins: group-remote-pins { > > Can we keep the established naming: > > $ git grep remote_input_ao_pins arch/arm64/boot/dts/amlogic/ | wc -l > > 37 > > > > I'm worried that adding IR blaster/output support at some point will > > then lead to confusion. > > > Will do. I will rename remote_input_ao_pins. I'm also happy with remote_input_d_pins or however the datasheet calls this pin/function (seeing that A9 has AO, C, D and TEST pins in the always-on domain). The part that's important for me: include "input" in the name (so it's clear that this is IR input, not IR output). _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic