Re: [PATCH v2 2/2] arm64: dts: amlogic: a9: Add IR controller support

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect indentation in the newly added `func-ir-in` DT node.
--

--- Patch [2]: [PATCH v2 2/2] arm64: dts: amlogic: a9: Add IR controller support ---
commit 170115242b4dcc46e2461f78dbc3a0882a8e80f1
Author: Xianwei Zhao <[email protected]>

arm64: dts: amlogic: a9: Add IR controller support

This commit adds the IR controller node for the Amlogic A9 SoC and describes
the remote input pin configuration. It also enables the IR controller on the
Amlogic A9 A311Y3 BY401 board with the appropriate pinctrl settings.

> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi
> index b0e0fadeed820..aa89b31bfe30d 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a9.dtsi
[ ... ]
> @@ -241,6 +241,13 @@ test_n: gpio@c0 {
>  					#gpio-cells = <2>;
>  					gpio-ranges = <&aobus_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>;
>  				};
> +
> +				func-ir-in {
> +						remote_input_ao_pins: group-remote-input-ao-pins {

[Severity: Low]
This isn't a bug, but does this indentation align with standard device tree
formatting? It looks like the remote_input_ao_pins node is indented with an
extra tab compared to the surrounding nodes and its own internal properties.

> +						pinmux = <AML_PINMUX(AMLOGIC_GPIO_D, 5, 1)>;
> +						bias-disable;
> +					};
> +				};
>  			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic