Re: [PATCH net-next v13 04/10] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Two bindings referencing snps,dwmac.yaml were missed when updating existing bindings with the `maxItems: 1` constraint for `power-domains`, unintentionally relaxing their validation bounds.
--

--- Patch [4]: [PATCH net-next v13 04/10] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems ---
commit f14d5198abd1c0f54fbb8e9d86982b940a5a6bc0
Author: Bartosz Golaszewski <[email protected]>

dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

Describe the firmware-managed variant of the QCom DesignWare MAC in a separate
file. This also updates the maximum number of power domains in snps,dwmac.yaml
and limits maxItems to 1 for existing bindings referencing it.

> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2449311c6d28e..d3aff1df3070d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
[ ... ]
> @@ -185,7 +186,8 @@ properties:
>            - const: ahb
>  
>    power-domains:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2

[Severity: Medium]
The commit message mentions updating existing bindings referencing
snps,dwmac.yaml to limit their power-domains maxItems to 1. However, it looks
like nuvoton,ma35d1-dwmac.yaml and spacemit,k3-dwmac.yaml were missed.

Because they rely on snps,dwmac.yaml and lack an explicit power-domains
definition, do they now unintentionally inherit this newly relaxed maxItems: 2
limit?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic