Re: [PATCH net-next v13 10/10] net: stmmac: qcom-ethqos: add support for sa8255p

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] ethqos_scmi_setup omits manual invocation of ethqos_clks_config(), which prevents MAC wrapper configuration during probe and leads to a DMA reset timeout.
--

--- Patch [10]: [PATCH net-next v13 10/10] net: stmmac: qcom-ethqos: add support for sa8255p ---
commit b7db35b4f8018859d3fc8937c25d0cfcf6c421f1
Author: Bartosz Golaszewski <[email protected]>

net: stmmac: qcom-ethqos: add support for sa8255p

Extend the driver to support the sa8255p model, which uses SCMI power
domains. This adds a new emac data variant and a separate setup callback.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> index 3af1608fc21cc..d34f20f868138 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

[ ... ]

> @@ -756,6 +788,63 @@ static int ethqos_hlos_setup(struct qcom_ethqos *ethqos,
>  	return 0;
>  }
>  
> +static const char *const ethqos_scmi_pd_names[] = { "core", "mdio" };
> +
> +static int ethqos_scmi_setup(struct qcom_ethqos *ethqos,
> +			     struct plat_stmmacenet_data *plat_dat)
> +{

[ ... ]

> +	/*
> +	 * Run on every runtime resume, which stmmac performs after the power
> +	 * domains are on but before serdes_powerup() and the DMA reset, so the
> +	 * wrapper is always configured ahead of the reset.
> +	 */
> +	plat_dat->clks_config = ethqos_clks_config;

[Severity: High]
Does this code need to explicitly call ethqos_clks_config() during probe?

The stmmac core brings the device out of suspend using pm_runtime_set_active()
during probe, which only updates the PM status but does not invoke the
runtime_resume callback. Without manually calling ethqos_clks_config() here,
will the wrapper clocks remain disabled and cause a DMA reset timeout?

> +	plat_dat->clk_ptp_rate = ethqos->data->ptp_clk_rate;
> +
> +	switch (ethqos->phy_mode) {
> +	case PHY_INTERFACE_MODE_2500BASEX:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic