Re: [PATCH v3] staging: media: meson: vdec: propagate devm_clk_get() errors
Dan Carpenter <[email protected]> Fri, 17 Jul 2026 08:51:32 +0300
| Newsgroups | org.infradead.lists.linux-amlogic,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Jul 17, 2026 at 08:35:58AM +0530, Alfie Varghese wrote: > vdec_probe() hardcodes -EPROBE_DEFER for all devm_clk_get() failures. > This masks the actual error code returned by the clock framework, such > as -ENOENT when a clock is not registered or -ENOMEM on allocation > failure. > > Return PTR_ERR() instead to propagate the real error to the caller. > > Reviewed-by: Dan Carpenter <[email protected]> > Signed-off-by: Alfie Varghese <[email protected]> > --- There is supposed to be a note here under the --- cut off line which says what changed. Did you resend just to add my Reviewed-by line? No need for that. regards, dan carpenter _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic