Re: [PATCH v2 02/15] drm/xlnx/zynqmp_dpsub: remove dependency on DRM simple helpers

On 7/20/2026 9:10 PM, Diogo Silva wrote:
> The simple KMS helpers are deprecated because they only add an
> intermediate layer between drivers and atomic modesetting.
> 
> Open-code drm_simple_encoder_init() by calling drm_encoder_init()
> directly and providing driver-local drm_encoder_funcs.
> Also check the return value from drm_encoder_init() to avoid silent
> failures.
> 
> Signed-off-by: Diogo Silva <[email protected]>

Reviewed-by: Radhey Shyam Pandey <[email protected]>
Thanks!
> ---
>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index d5f922450565..ac9197e026af 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -29,8 +29,8 @@
>   #include <drm/drm_managed.h>
>   #include <drm/drm_mode_config.h>
>   #include <drm/drm_plane.h>
> +#include <drm/drm_print.h>
>   #include <drm/drm_probe_helper.h>
> -#include <drm/drm_simple_kms_helper.h>
>   #include <drm/drm_vblank.h>
>   
>   #include <linux/clk.h>
> @@ -417,6 +417,10 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = {
>   	.minor				= 0,
>   };
>   
> +static const struct drm_encoder_funcs zynqmp_dpsub_encoder_funcs = {
> +	.destroy = drm_encoder_cleanup,
> +};
> +
>   static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub)
>   {
>   	struct drm_encoder *encoder = &dpsub->drm->encoder;
> @@ -436,7 +440,13 @@ static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub)
>   
>   	/* Create the encoder and attach the bridge. */
>   	encoder->possible_crtcs |= drm_crtc_mask(&dpsub->drm->crtc);
> -	drm_simple_encoder_init(&dpsub->drm->dev, encoder, DRM_MODE_ENCODER_NONE);
> +	ret = drm_encoder_init(&dpsub->drm->dev, encoder,
> +			       &zynqmp_dpsub_encoder_funcs,
> +			       DRM_MODE_ENCODER_NONE, NULL);
> +	if (ret) {
> +		drm_err(&dpsub->drm->dev, "failed to initialize encoder\n");
> +		return ret;
> +	}
>   
>   	ret = drm_bridge_attach(encoder, dpsub->bridge, NULL,
>   				DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> 


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic