Re: [PATCH v3 3/4] nvmem: apple-spmi: improve calling safety with wrapper functions

Link Mauve <[email protected]> Sun, 26 Jul 2026 14:56:16 +0200
Newsgroups org.infradead.lists.linux-amlogic,dev.linux.lists.asahi,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux
Message-ID <amYD8I6a1c01fnvs@luna>
QWgsIHNvbWVvbmUgaW5kZXBlbmRlbnRseSBzZW50IHRoZSBzYW1lIHBhdGNoIGFzIHRoaXMgb25l
IGluCjcwODkxNzBlMWRmMTYwZjVmOGZiMzk1YmM1YWEyZTI2OTdiNGU4OTYsIHNvIEnigJlsbCBk
cm9wIGl0IGZyb20gdjQuCgpTb3JyeSBpdCB0b29rIHRoYXQgbG9uZyEKCk9uIFRodSwgSnVsIDE2
LCAyMDI2IGF0IDA5OjA3OjEzUE0gKzAzMDAsIEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiBPbiBU
aHUsIEp1bCAxNiwgMjAyNiBhdCAwNDoyNDoxMFBNICswMjAwLCBMaW5rIE1hdXZlIHdyb3RlOgo+
ID4gVGhpcyBkcml2ZXIgdXNlZCB0byBjYXN0IHRoZSByZWdtYXBfYnVsa18qKCkgZnVuY3Rpb25z
IHRvIHZvaWQgKiwKPiA+IGJ5cGFzc2luZyBhbnkgY29tcGlsZXIgc2FmZXR5IGFyb3VuZCBpbmNv
bXBhdGlibGUgZnVuY3Rpb24gcG9pbnRlcnMuCj4gPiAKPiA+IFdpdGggdHdvIHNtYWxsIHdyYXBw
ZXJzLCB3aGljaCBqdXN0IGNvbnZlcnQgdGhlIHZvaWQgKiBwcml2IHBhcmFtZXRlcgo+ID4gaW50
byB0aGUgd2FudGVkIHN0cnVjdCByZWdtYXAgKiwgd2UgY2FuIHJlbW92ZSB0aGUgdm9pZCAqIGNh
c3QKPiA+IGFsdG9nZXRoZXIuCj4gCj4gUmVwb3J0ZWQtYnk6ID8KPiAKPiA+IFNpZ25lZC1vZmYt
Ynk6IExpbmsgTWF1dmUgPGxpbmttYXV2ZUBsaW5rbWF1dmUuZnI+Cj4gCj4gLi4uCj4gCj4gPiAr
c3RhdGljIGludCBhcHBsZV9zcG1pX252bWVtX3JlYWQodm9pZCAqcHJpdiwgdW5zaWduZWQgaW50
IG9mZnNldCwKPiA+ICsJCQkJIHZvaWQgKnZhbCwgc2l6ZV90IGJ5dGVzKQo+ID4gK3sKPiAKPiA+
ICsJc3RydWN0IHJlZ21hcCAqcmVnbWFwID0gcHJpdjsKPiAKPiBObyBuZWVkIDotKQo+IAo+ID4g
KwlyZXR1cm4gcmVnbWFwX2J1bGtfcmVhZChyZWdtYXAsIG9mZnNldCwgdmFsLCBieXRlcyk7Cj4g
PiArfQo+IAo+IHN0YXRpYyBpbnQgYXBwbGVfc3BtaV9udm1lbV9yZWFkKHZvaWQgKm1hcCwgdW5z
aWduZWQgaW50IG9mZnNldCwKPiAJCQkJIHZvaWQgKnZhbCwgc2l6ZV90IGJ5dGVzKQo+IHsKPiAJ
cmV0dXJuIHJlZ21hcF9idWxrX3JlYWQobWFwLCBvZmZzZXQsIHZhbCwgYnl0ZXMpOwo+IH0KPiAK
PiAuLi4KPiAKPiA+ICtzdGF0aWMgaW50IGFwcGxlX3NwbWlfbnZtZW1fd3JpdGUodm9pZCAqcHJp
diwgdW5zaWduZWQgaW50IG9mZnNldCwKPiA+ICsJCQkJICBjb25zdCB2b2lkICp2YWwsIHNpemVf
dCBieXRlcykKPiA+ICt7Cj4gPiArCXN0cnVjdCByZWdtYXAgKnJlZ21hcCA9IHByaXY7Cj4gPiAr
CXJldHVybiByZWdtYXBfYnVsa193cml0ZShyZWdtYXAsIG9mZnNldCwgdmFsLCBieXRlcyk7Cj4g
PiArfQo+IAo+IEluIHRoZSBzaW1pbGFyIHdheSBhcyBhYm92ZS4KPiAKPiAuLi4KPiAKPiA+IC0J
CS5yZWdfcmVhZCA9ICh2b2lkICopcmVnbWFwX2J1bGtfcmVhZCwKPiA+IC0JCS5yZWdfd3JpdGVf
Y29uc3QgPSAodm9pZCAqKXJlZ21hcF9idWxrX3dyaXRlLAo+ID4gKwkJLnJlZ19yZWFkID0gYXBw
bGVfc3BtaV9udm1lbV9yZWFkLAo+ID4gKwkJLnJlZ193cml0ZV9jb25zdCA9IGFwcGxlX3NwbWlf
bnZtZW1fd3JpdGUsCj4gCj4gSSB0aGluayB0aGUgcHJvcGVyIG9yZGVyaW5nIGlzIHRvIGFkZHJl
c3MgdGhpcyBmaXJzdCAoYmVmb3JlIHlvdXIgbWFpbiBjaGFuZ2UpCj4gYW5kIHVwZGF0ZSBsYXRl
ciB3aXRoIGNvbnN0IGFyZ3VtZW50LiBZZXMsIGl0IHdpbGwgYmUgYSBiaXQgbW9yZSBjaGFuZ2Vz
LCBidXQKPiBpdCB3aWxsIGJlIGNsZWFuZXIuCj4gCj4gLS0gCj4gV2l0aCBCZXN0IFJlZ2FyZHMs
Cj4gQW5keSBTaGV2Y2hlbmtvCj4gCj4gCgotLSAKTGluayBNYXV2ZQoKX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxp
c3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl
YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=