Re: [PATCH] mmc: host: Remove redundant dev_err()/dev_err_probe()
Ulf Hansson <[email protected]> Mon, 27 Jul 2026 18:25:00 +0200
| Newsgroups | org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mmc,org.kernel.vger.linux-omap |
|---|---|
| Message-ID | <CAPx+jO_fcijCoA0UEPS359EZKgzEtjP3EYKt48r7ryOz6RT12A@mail.gmail.com> |
T24gRnJpLCBKdWwgMTcsIDIwMjYgYXQgMTI6MTfigK9QTSBQYW4gQ2h1YW5nIDxwYW5jaHVhbmdA dml2by5jb20+IHdyb3RlOgo+Cj4gU2luY2UgY29tbWl0IDU1YjQ4ZTIzZjVjNCAoImdlbmlycS9k ZXZyZXM6IEFkZCBlcnJvciBoYW5kbGluZyBpbgo+IGRldm1fcmVxdWVzdF8qX2lycSgpIiksIGRl dm1fcmVxdWVzdF9pcnEoKSBhbmQgZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycSgpCj4gYXV0b21h dGljYWxseSBsb2cgZGV0YWlsZWQgZXJyb3IgbWVzc2FnZXMgb24gZmFpbHVyZS4gUmVtb3ZlIHRo ZQo+IG5vdy1yZWR1bmRhbnQgZHJpdmVyLXNwZWNpZmljIGRldl9lcnIoKSBhbmQgZGV2X2Vycl9w cm9iZSgpIGNhbGxzLgo+Cj4gU2lnbmVkLW9mZi1ieTogUGFuIENodWFuZyA8cGFuY2h1YW5nQHZp dm8uY29tPgoKQXBwbGllZCBmb3IgbmV4dCwgdGhhbmtzIQoKS2luZCByZWdhcmRzClVmZmUKCgo+ IC0tLQo+ICBkcml2ZXJzL21tYy9ob3N0L2FsY29yLmMgICAgICAgICB8ICAzICstLQo+ICBkcml2 ZXJzL21tYy9ob3N0L2Nhdml1bS1vY3Rlb24uYyB8IDEwICsrLS0tLS0tLS0KPiAgZHJpdmVycy9t bWMvaG9zdC9tZXNvbi1teC1zZGlvLmMgfCAgNSArLS0tLQo+ICBkcml2ZXJzL21tYy9ob3N0L212 c2Rpby5jICAgICAgICB8ICA0ICstLS0KPiAgZHJpdmVycy9tbWMvaG9zdC9vbWFwX2hzbW1jLmMg ICAgfCAgNCArLS0tCj4gIGRyaXZlcnMvbW1jL2hvc3Qvb3dsLW1tYy5jICAgICAgIHwgIDUgKy0t LS0KPiAgZHJpdmVycy9tbWMvaG9zdC9zZGhjaS1tc20uYyAgICAgfCAgNCArLS0tCj4gIGRyaXZl cnMvbW1jL2hvc3Qvc2hfbW1jaWYuYyAgICAgIHwgIDggKystLS0tLS0KPiAgOCBmaWxlcyBjaGFu Z2VkLCAxMCBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL21tYy9ob3N0L2FsY29yLmMgYi9kcml2ZXJzL21tYy9ob3N0L2FsY29yLmMKPiBpbmRl eCA3MjFkYjU0NzM5YzEuLjQ1NTI4OTA5YTc1OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21tYy9o b3N0L2FsY29yLmMKPiArKysgYi9kcml2ZXJzL21tYy9ob3N0L2FsY29yLmMKPiBAQCAtMTEwMyw4 ICsxMTAzLDcgQEAgc3RhdGljIGludCBhbGNvcl9wY2lfc2RtbWNfZHJ2X3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAgICAgICAgICAgICAgICAgICAgYWxjb3JfaXJx LCBhbGNvcl9pcnFfdGhyZWFkLCBJUlFGX1NIQVJFRCwKPiAgICAgICAgICAgICAgICAgICAgICAg ICBEUlZfTkFNRV9BTENPUl9QQ0lfU0RNTUMsIGhvc3QpOwo+ICAgICAgICAgaWYgKHJldCkKPiAt ICAgICAgICAgICAgICAgcmV0dXJuIGRldl9lcnJfcHJvYmUoJnBkZXYtPmRldiwgcmV0LAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiRmFpbGVkIHRvIGdldCBpcnEgZm9y IGRhdGEgbGluZVxuIik7Cj4gKyAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4KPiAgICAgICAg IG11dGV4X2luaXQoJmhvc3QtPmNtZF9tdXRleCk7Cj4gICAgICAgICBJTklUX0RFTEFZRURfV09S SygmaG9zdC0+dGltZW91dF93b3JrLCBhbGNvcl90aW1lb3V0X3RpbWVyKTsKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9tbWMvaG9zdC9jYXZpdW0tb2N0ZW9uLmMgYi9kcml2ZXJzL21tYy9ob3N0L2Nh dml1bS1vY3Rlb24uYwo+IGluZGV4IDhhMGRhZGRkOTIwMC4uMWJmYzFhNGY5ZmU5IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvbW1jL2hvc3QvY2F2aXVtLW9jdGVvbi5jCj4gKysrIGIvZHJpdmVycy9t bWMvaG9zdC9jYXZpdW0tb2N0ZW9uLmMKPiBAQCAtMjQwLDIxICsyNDAsMTUgQEAgc3RhdGljIGlu dCBvY3Rlb25fbW1jX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAg ICAgICAgICAgICAgICAgICAgcmV0ID0gZGV2bV9yZXF1ZXN0X2lycSgmcGRldi0+ZGV2LCBtbWNf aXJxW2ldLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y3ZtX21tY19pbnRlcnJ1cHQsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAwLCBjdm1fbW1jX2lycV9uYW1lc1tpXSwgaG9zdCk7Cj4gLSAgICAgICAgICAg ICAgICAgICAgICAgaWYgKHJldCA8IDApIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGRldl9lcnIoJnBkZXYtPmRldiwgIkVycm9yOiBkZXZtX3JlcXVlc3RfaXJxICVkXG4iLAo+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtbWNfaXJxW2ldKTsKPiAr ICAgICAgICAgICAgICAgICAgICAgICBpZiAocmV0IDwgMCkKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgfQo+ICAg ICAgICAgICAgICAgICB9Cj4gICAgICAgICB9IGVsc2Ugewo+ICAgICAgICAgICAgICAgICByZXQg PSBkZXZtX3JlcXVlc3RfaXJxKCZwZGV2LT5kZXYsIG1tY19pcnFbMF0sCj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY3ZtX21tY19pbnRlcnJ1cHQsIDAsIEtCVUlMRF9N T0ROQU1FLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhvc3QpOwo+ IC0gICAgICAgICAgICAgICBpZiAocmV0IDwgMCkgewo+IC0gICAgICAgICAgICAgICAgICAgICAg IGRldl9lcnIoJnBkZXYtPmRldiwgIkVycm9yOiBkZXZtX3JlcXVlc3RfaXJxICVkXG4iLAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW1jX2lycVswXSk7Cj4gKyAgICAgICAgICAg ICAgIGlmIChyZXQgPCAwKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4g LSAgICAgICAgICAgICAgIH0KPiAgICAgICAgIH0KPgo+ICAgICAgICAgaG9zdC0+Z2xvYmFsX3B3 cl9ncGlvZCA9IGRldm1fZ3Bpb2RfZ2V0X29wdGlvbmFsKCZwZGV2LT5kZXYsCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbW1jL2hvc3QvbWVzb24tbXgtc2Rpby5jIGIvZHJpdmVycy9tbWMvaG9zdC9t ZXNvbi1teC1zZGlvLmMKPiBpbmRleCA1OTIxZTJjYjIxODAuLmJlZjVlODQzZjQ0OSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL21tYy9ob3N0L21lc29uLW14LXNkaW8uYwo+ICsrKyBiL2RyaXZlcnMv bW1jL2hvc3QvbWVzb24tbXgtc2Rpby5jCj4gQEAgLTY4MywxMSArNjgzLDggQEAgc3RhdGljIGlu dCBtZXNvbl9teF9tbWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWVzb25fbXhfbW1jX2lycSwKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWVzb25fbXhfbW1jX2lycV90 aHJlYWQsIElSUUZfT05FU0hPVCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgTlVMTCwgaG9zdCk7Cj4gLSAgICAgICBpZiAocmV0KSB7Cj4gLSAgICAgICAgICAgICAg IGRldl9lcnJfcHJvYmUoaG9zdC0+Y29udHJvbGxlcl9kZXYsIHJldCwKPiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiRmFpbGVkIHRvIHJlcXVlc3QgSVJRXG4iKTsKPiArICAgICAgIGlm IChyZXQpCj4gICAgICAgICAgICAgICAgIGdvdG8gZXJyb3JfdW5yZWdpc3Rlcl9zbG90X3BkZXY7 Cj4gLSAgICAgICB9Cj4KPiAgICAgICAgIGNvcmVfY2xrID0gZGV2bV9jbGtfZ2V0X2VuYWJsZWQo aG9zdC0+Y29udHJvbGxlcl9kZXYsICJjb3JlIik7Cj4gICAgICAgICBpZiAoSVNfRVJSKGNvcmVf Y2xrKSkgewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21tYy9ob3N0L212c2Rpby5jIGIvZHJpdmVy cy9tbWMvaG9zdC9tdnNkaW8uYwo+IGluZGV4IDc5ZGYyZmE4OWEzZi4uY2Y3MDViMjY1ZTIxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbW1jL2hvc3QvbXZzZGlvLmMKPiArKysgYi9kcml2ZXJzL21t Yy9ob3N0L212c2Rpby5jCj4gQEAgLTc2NCwxMCArNzY0LDggQEAgc3RhdGljIGludCBtdnNkX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAgICBtdnNkX3Bvd2VyX2Rv d24oaG9zdCk7Cj4KPiAgICAgICAgIHJldCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwg aXJxLCBtdnNkX2lycSwgMCwgRFJJVkVSX05BTUUsIGhvc3QpOwo+IC0gICAgICAgaWYgKHJldCkg ewo+IC0gICAgICAgICAgICAgICBkZXZfZXJyKCZwZGV2LT5kZXYsICJjYW5ub3QgYXNzaWduIGly cSAlZFxuIiwgaXJxKTsKPiArICAgICAgIGlmIChyZXQpCj4gICAgICAgICAgICAgICAgIGdvdG8g b3V0Owo+IC0gICAgICAgfQo+Cj4gICAgICAgICB0aW1lcl9zZXR1cCgmaG9zdC0+dGltZXIsIG12 c2RfdGltZW91dF90aW1lciwgMCk7Cj4gICAgICAgICBwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2 LCBtbWMpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21tYy9ob3N0L29tYXBfaHNtbWMuYyBiL2Ry aXZlcnMvbW1jL2hvc3Qvb21hcF9oc21tYy5jCj4gaW5kZXggNThjODgxZjI3MjViLi42M2E5ZmI5 NzA5NzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tbWMvaG9zdC9vbWFwX2hzbW1jLmMKPiArKysg Yi9kcml2ZXJzL21tYy9ob3N0L29tYXBfaHNtbWMuYwo+IEBAIC0xOTE1LDEwICsxOTE1LDggQEAg c3RhdGljIGludCBvbWFwX2hzbW1jX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp Cj4gICAgICAgICAvKiBSZXF1ZXN0IElSUSBmb3IgTU1DIG9wZXJhdGlvbnMgKi8KPiAgICAgICAg IHJldCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgaG9zdC0+aXJxLCBvbWFwX2hzbW1j X2lycSwgMCwKPiAgICAgICAgICAgICAgICAgICAgICAgICBtbWNfaG9zdG5hbWUobW1jKSwgaG9z dCk7Cj4gLSAgICAgICBpZiAocmV0KSB7Cj4gLSAgICAgICAgICAgICAgIGRldl9lcnIobW1jX2Rl dihob3N0LT5tbWMpLCAiVW5hYmxlIHRvIGdyYWIgSFNNTUMgSVJRXG4iKTsKPiArICAgICAgIGlm IChyZXQpCj4gICAgICAgICAgICAgICAgIGdvdG8gZXJyX2lycTsKPiAtICAgICAgIH0KPgo+ICAg ICAgICAgcmV0ID0gb21hcF9oc21tY19yZWdfZ2V0KGhvc3QpOwo+ICAgICAgICAgaWYgKHJldCkK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tbWMvaG9zdC9vd2wtbW1jLmMgYi9kcml2ZXJzL21tYy9o b3N0L293bC1tbWMuYwo+IGluZGV4IDM0OTA4MmQ3NmE5OS4uZDViOGExMTAyNjdiIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvbW1jL2hvc3Qvb3dsLW1tYy5jCj4gKysrIGIvZHJpdmVycy9tbWMvaG9z dC9vd2wtbW1jLmMKPiBAQCAtNjM1LDExICs2MzUsOCBAQCBzdGF0aWMgaW50IG93bF9tbWNfcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPgo+ICAgICAgICAgcmV0ID0gZGV2bV9y ZXF1ZXN0X2lycSgmcGRldi0+ZGV2LCBvd2xfaG9zdC0+aXJxLCBvd2xfaXJxX2hhbmRsZXIsCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAsIGRldl9uYW1lKCZwZGV2LT5kZXYpLCBv d2xfaG9zdCk7Cj4gLSAgICAgICBpZiAocmV0KSB7Cj4gLSAgICAgICAgICAgICAgIGRldl9lcnIo JnBkZXYtPmRldiwgIkZhaWxlZCB0byByZXF1ZXN0IGlycSAlZFxuIiwKPiAtICAgICAgICAgICAg ICAgICAgICAgICBvd2xfaG9zdC0+aXJxKTsKPiArICAgICAgIGlmIChyZXQpCj4gICAgICAgICAg ICAgICAgIGdvdG8gZXJyX3JlbGVhc2VfY2hhbm5lbDsKPiAtICAgICAgIH0KPgo+ICAgICAgICAg cmV0ID0gbW1jX2FkZF9ob3N0KG1tYyk7Cj4gICAgICAgICBpZiAocmV0KSB7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbW1jL2hvc3Qvc2RoY2ktbXNtLmMgYi9kcml2ZXJzL21tYy9ob3N0L3NkaGNp LW1zbS5jCj4gaW5kZXggY2VlZDQ3Y2NmZGE4Li40YWZmOTY1ZjBlMmUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9tbWMvaG9zdC9zZGhjaS1tc20uYwo+ICsrKyBiL2RyaXZlcnMvbW1jL2hvc3Qvc2Ro Y2ktbXNtLmMKPiBAQCAtMjg2NCwxMCArMjg2NCw4IEBAIHN0YXRpYyBpbnQgc2RoY2lfbXNtX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAgICByZXQgPSBkZXZtX3Jl cXVlc3RfdGhyZWFkZWRfaXJxKCZwZGV2LT5kZXYsIG1zbV9ob3N0LT5wd3JfaXJxLCBOVUxMLAo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZGhjaV9tc21fcHdyX2ly cSwgSVJRRl9PTkVTSE9ULAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBkZXZfbmFtZSgmcGRldi0+ZGV2KSwgaG9zdCk7Cj4gLSAgICAgICBpZiAocmV0KSB7Cj4gLSAg ICAgICAgICAgICAgIGRldl9lcnIoJnBkZXYtPmRldiwgIlJlcXVlc3QgSVJRIGZhaWxlZCAoJWQp XG4iLCByZXQpOwo+ICsgICAgICAgaWYgKHJldCkKPiAgICAgICAgICAgICAgICAgZ290byBjbGtf ZGlzYWJsZTsKPiAtICAgICAgIH0KPgo+ICAgICAgICAgbXNtX2hvc3QtPm1tYy0+Y2FwcyB8PSBN TUNfQ0FQX1dBSVRfV0hJTEVfQlVTWSB8IE1NQ19DQVBfTkVFRF9SU1BfQlVTWTsKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL21tYy9ob3N0L3NoX21tY2lmLmMgYi9kcml2ZXJzL21tYy9ob3N0L3No X21tY2lmLmMKPiBpbmRleCA5ODMxOTU2ZGUxYzguLjc3MDZkMDFiMTQ5ZSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL21tYy9ob3N0L3NoX21tY2lmLmMKPiArKysgYi9kcml2ZXJzL21tYy9ob3N0L3No X21tY2lmLmMKPiBAQCAtMTUwNSwxOCArMTUwNSwxNCBAQCBzdGF0aWMgaW50IHNoX21tY2lmX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAgICBuYW1lID0gaXJxWzFd IDwgMCA/IGRldl9uYW1lKGRldikgOiAic2hfbW1jOmVycm9yIjsKPiAgICAgICAgIHJldCA9IGRl dm1fcmVxdWVzdF90aHJlYWRlZF9pcnEoZGV2LCBpcnFbMF0sIHNoX21tY2lmX2ludHIsCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNoX21tY2lmX2lycXQsIDAsIG5h bWUsIGhvc3QpOwo+IC0gICAgICAgaWYgKHJldCkgewo+IC0gICAgICAgICAgICAgICBkZXZfZXJy KGRldiwgInJlcXVlc3RfaXJxIGVycm9yICglcylcbiIsIG5hbWUpOwo+ICsgICAgICAgaWYgKHJl dCkKPiAgICAgICAgICAgICAgICAgZ290byBlcnJfY2xrOwo+IC0gICAgICAgfQo+ICAgICAgICAg aWYgKGlycVsxXSA+PSAwKSB7Cj4gICAgICAgICAgICAgICAgIHJldCA9IGRldm1fcmVxdWVzdF90 aHJlYWRlZF9pcnEoZGV2LCBpcnFbMV0sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc2hfbW1jaWZfaW50ciwgc2hfbW1jaWZfaXJxdCwKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwLCAic2hfbW1jOmludCIs IGhvc3QpOwo+IC0gICAgICAgICAgICAgICBpZiAocmV0KSB7Cj4gLSAgICAgICAgICAgICAgICAg ICAgICAgZGV2X2VycihkZXYsICJyZXF1ZXN0X2lycSBlcnJvciAoc2hfbW1jOmludClcbiIpOwo+ ICsgICAgICAgICAgICAgICBpZiAocmV0KQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8g ZXJyX2NsazsKPiAtICAgICAgICAgICAgICAgfQo+ICAgICAgICAgfQo+Cj4gICAgICAgICBtdXRl eF9pbml0KCZob3N0LT50aHJlYWRfbG9jayk7Cj4gLS0KPiAyLjM0LjEKPgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5n IGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=