Re: [PATCH v7 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder

在 2026/8/13 17:22, Krzysztof Kozlowski 写道:
> [ EXTERNAL EMAIL ]
>
> On 13/08/2026 10:39, Zhentao Guo wrote:
>> Hi Krzysztof
>>
>>> On Wed, Aug 12, 2026 at 10:41:25AM +0800, Zhentao Guo wrote:
>>>> Describe the initial support for the V4L2 stateless video decoder
>>>> driver used with the Amlogic S4 (S805X2) platform.
>>>>
>>>> Signed-off-by: Zhentao Guo <[email protected]>
>>>> ---
>>>>    .../devicetree/bindings/media/amlogic,s4-vdec.yaml | 111 +++++++++++++++++++++
>>>>    1 file changed, 111 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
>>>> new file mode 100644
>>>> index 000000000000..b5af3f931b26
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
>>>> @@ -0,0 +1,111 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +# Copyright (C) 2025 Amlogic, Inc. All rights reserved
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/media/amlogic,s4-vdec.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Amlogic Video Decode Accelerator
>>>> +
>>>> +maintainers:
>>>> +  - Zhentao Guo <[email protected]>
>>>> +
>>>> +description:
>>>> +  The Video Decoder Accelerator present on Amlogic SOCs.
>>>> +  It supports stateless h264 decoding.
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: amlogic,s4-vdec
>>>> +
>>>> +  reg:
>>>> +    maxItems: 2
>>>> +
>>>> +  reg-names:
>>>> +    items:
>>>> +      - const: dos
>>>> +      - const: dmc
>>>> +
>>>> +  interrupts:
>>>> +    maxItems: 2
>>>> +
>>>> +  interrupt-names:
>>>> +    items:
>>>> +      - const: hvdec
>>>> +      - const: vdec
>>> vdec is the name of the module, so not really useful name.
>> Ok, I'll come up with a new name and change it in the next revision.
>>>> +
>>>> +  clocks:
>>>> +    maxItems: 3
>>>> +
>>>> +  clock-names:
>>>> +    items:
>>>> +      - const: dos
>>>> +      - const: vdec
>>> Same here
>> OK, but there would be a nit. In file
>> drivers/soc/amlogic/meson-clk-measure.c, This clock source is also named
>> *"vdec"*in|drivers/soc/amlogic/meson-clk-measure.c|, where a
> Source does not matter. You do not describe here the source, but this
> device. How is the input called in this device, not in the source?
Yes, I get what you mean.
>> *"vdec"*clock node is created in debugfs for checking its status. Using
>> a different name in the driver (including DT and binding) would make it
>> inconsistent with the debugfs node naming.
> What inconsistency? How would provider name matter?
This isn't actually a provider name either, it merely defines a debug 
node and names it "vdec". I dose not matter, I'll rename the clock in 
the device.
>
> Best regards,
> Krzysztof

BRs

Zhentao


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic