Re: [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible
Gregor Herburger <[email protected]> Tue, 4 Aug 2026 10:38:25 +0200
| Newsgroups | org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <zl5z6owx4v5kg2ian7twpggekaosrenbhvgjq7fimm5j2ptz4i@ygvudatdkems> |
On Tue, Aug 04, 2026 at 09:48:19AM +0200, Krzysztof Kozlowski wrote: > On Mon, Aug 03, 2026 at 02:09:25PM +0200, Gregor Herburger wrote: > > The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping > > and in a c Stepping. There are two separate dts files. The > > bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for > > the d Stepping. The d stepping does not set its own compatible/model > > string but uses "raspberrypi,5-model-b". > > > > These two steppings are not compatible. Booting with the wrong dtb file > > Not compatible but... > > > causes a crash at boot. > > > > Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to > > distinguish between those two steppings. > > > > Signed-off-by: Gregor Herburger <[email protected]> > > --- > > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > > index 127be0fc27c2..11a38cd53401 100644 > > --- a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > > @@ -3,6 +3,11 @@ > > > > #include "bcm2712-rpi-5-b.dts" > > > > +/ { > > + compatible = "raspberrypi,5-model-b-d0", "raspberrypi,5-model-b", "brcm,bcm2712"; > > this tells they are compatible. If compatibility was wrong since the > beginning, you do not have to preserve the ABI. Ok understood. Will drop the fallback and make it either compatible = "raspberrypi,5-model-b-d0", "brcm,bcm2712"; or compatible = "raspberrypi,5-model-b", "brcm,bcm2712"; > > Best regards, > Krzysztof > Best regards, -- Gregor Herburger Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen Phone: +49 7556 25 999 35; Fax.: +49 7556 25 999 99 Hinweise zum Datenschutz finden Sie hier (Informations on data privacy can be found here): https://linutronix.de/legal/data-protection.php Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 806 | Geschäftsführer (Managing Directors): Dr. Wilfried Wessner, Katharina Kopp, Alexander Gieringer